Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the API request on fetching contributors #1179

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fixed the API request on fetching contributors #1179

merged 2 commits into from
Jun 10, 2024

Conversation

pandeyji711
Copy link
Contributor

@pandeyji711 pandeyji711 commented Jun 4, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #996

Description👨‍💻

Now API limited increased to 5000 pr hr.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

Tested on my local machine.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot 2024-06-02 110439

@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 69b57dc
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6661b6eaa1c1060008001a4d
😎 Deploy Preview https://deploy-preview-1179--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Jun 4, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pandeyji711, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@pandeyji711 pandeyji711 mentioned this pull request Jun 4, 2024
Closed
6 tasks
@Rakesh9100 Rakesh9100 changed the title fixed api fetch issue Fixed the API request on fetching contributors Jun 6, 2024
@Rakesh9100
Copy link
Owner

https://deploy-preview-1179--calcdiverse.netlify.app/assets/contributors/contributor

Pls check the deploy preview, why all the contributors are taking time to load @pandeyji711

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 6, 2024
@pandeyji711
Copy link
Contributor Author

https://deploy-preview-1179--calcdiverse.netlify.app/assets/contributors/contributor

Pls check the deploy preview, why all the contributors are taking time to load @pandeyji711

@Rakesh9100 becouse api token is fetch from google app scrip
i added one loading animation after that

@Rakesh9100
Copy link
Owner

Have you added the loading animation or will add @pandeyji711

@pandeyji711
Copy link
Contributor Author

pandeyji711 commented Jun 6, 2024 •
edited
Loading

Have you added the loading animation or will add @pandeyji711
@Rakesh9100
after merge i will add

@pandeyji711
Copy link
Contributor Author

pandeyji711 commented Jun 6, 2024 •
edited
Loading

Have you added the loading animation or will add @pandeyji711
@Rakesh9100
becouse i have to cheak for it working on production or not

@Rakesh9100
Copy link
Owner

I can't merge as it is taking too much time to load, the previous one is only fine which loads all the contributors immediately @pandeyji711

@pandeyji711
Copy link
Contributor Author

pandeyji711 commented Jun 10, 2024 •
edited
Loading

I can't merge as it is taking too much time to load, the previous one is only fine which loads all the contributors immediately @pandeyji711

@Rakesh9100 I will add loading animation it works fine then

@Rakesh9100 Rakesh9100 merged commit 9fd604e into Rakesh9100:main Jun 10, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @pandeyji711

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task and removed question 🤔 Further information is requested labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@pandeyji711 pandeyji711

Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix the API request on fetching contributors
2 participants
@pandeyji711 @Rakesh9100